Skip to content

Comments

chore: backport minor fixes and refactorings from abandoned branch#10

Merged
jvanstraten merged 2 commits intosubstrait-io:mainfrom
jvanstraten:backports-from-failed-simple-extensions
Jun 2, 2022
Merged

chore: backport minor fixes and refactorings from abandoned branch#10
jvanstraten merged 2 commits intosubstrait-io:mainfrom
jvanstraten:backports-from-failed-simple-extensions

Conversation

@jvanstraten
Copy link
Collaborator

Changes:

  • Refactor string_util to util::string. Better to do it sooner than later, even though the string module is the only child of util right now. Signals intent that util is where all misc things that are not necessarily specific to the validator should go.
  • Implement some Eq/Hash traits.
  • Extend the syntax for what the validator considers to be an identifier in accordance with the ANTLR grammar and u! user-defined type prefix (the validator simply uses this to determine whether it should print something that should be a valid identifier with or without quotes in the HTML output).
  • Fix some typos in comments.

Abandoned branch being my third (I think) attempt at type expression support; it was getting way too complicated the way I was doing it.

@jvanstraten
Copy link
Collaborator Author

CI failure should go away after #2 is merged.

@jvanstraten jvanstraten force-pushed the backports-from-failed-simple-extensions branch from d042589 to d084375 Compare May 30, 2022 18:55
@jvanstraten jvanstraten force-pushed the backports-from-failed-simple-extensions branch from d084375 to cf0774d Compare May 30, 2022 19:16
@jvanstraten jvanstraten merged commit 596e12f into substrait-io:main Jun 2, 2022
@jvanstraten jvanstraten deleted the backports-from-failed-simple-extensions branch June 2, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants